RRReviewers

From PostgreSQL Wiki

Contents 1 What's a Round Robin Reviewer (RRR)? 2 What do I need to do to become an RRR? 3 What happens next? 4 Guidelines for Review

What's a Round Robin Reviewer (RRR)?

Round Robin Reviewers are hackers who volunteer to be assigned random patches (usually according to their level of ability) to review during a commitfest by the CommitFest Manager. They generally have at least good C skills and a general knowledge of PostgreSQL, but some are accomplished PostgreSQL hackers.

What do I need to do to become an RRR?

1. Subscribe to the pgsql-hackers and the pgsql-rrreviewers mailing lists.
2. Volunteer to review on pgsql-rrreviewers.
3. Sign up for an account on this wiki.
4. Read the CommitFest Help and the Reviewing a Patch page, and the pages & docs they links to.

What happens next?

1. The CommitFest Manager will assign you a patch by e-mail.
2. You'll visit commitfest.postgresql.org, edit the patch, and put your name down as a reviewer.
3. If you can't or don't want to review that patch, you will reject it within 24 hours (and be assigned a new patch if appropriate).
4. You'll read the information on the patch and search the mailing list archives for other comments related to the patch.
5. You review the patch within 4 days.
6. As a result of reviewing, one of two things will happen:
   1. If the patch needs work:
      1. Reply to mail thread on -hackers with comments; make sure the submitter is cc'd.
      2. Put a summary of your comments on commitfest.postgresql.org
      3. Change the status to "Waiting on Author"
      4. Leave "close date" blank
   2. If the patch seems ready to accept to you, then you will change the status to "Ready for Committer".
   3. If the patch shouldn't be further considered for this commitfest, then you will change the status to "Returned with Feedback" or "Rejected". Enter a "close date".
7. In any case, you will then e-mail the CommitFest Manager that you are ready to work with another patch.

Note that, if you are assigned a "WIP" patch, it is unlikely to be ready for committing. Instead, you should test the patch as best you can, and report on it to pgsql-hackers.

Guidelines for Review

• Be polite to the patch submitters. You'll probably be one yourself someday.
• Raise any questions you have on pgsql-hackers mailing list.
• Don't hesitate to ask for help; a poorly done review will slow down the CommitFest far more than not reviewing at all.
• You are helping out in order to reduce the workload on the committers. Do as much as you can, then stop.
• Contact the CommitFest Manager immediately if you won't be able to complete a review.
• When reading from the mail archives, make sure to read the entire thread about the patch.