CommitFest 2008-07

This page contains historical information or deprecated articles.

⇐ Previous CommitFest	This CommitFest	Next CommitFest ⇒
2008-05	2008-07	2008-09

CommitFest

This is the page for CommitFest starting July 2008

This commitfest is now closed All items in this commitfest have been reviewed and actioned. If you have a new patch to submit, please add it at CommitFestOpen.

Pending patches

Patch	Status	Author	Reviewers

Committed patches

Patch	Status	Author	Reviewers
psql: \timing as a boolean arg	Committed 2008-06-11	David Fetter	Heikki Linnakangas
small typo in DTrace docs	Committed 2008-06-18	Euler Taveira de Oliveira	Neil Conway
alvherre says: Note another typo "definitons" in patch
GUC variable to replace PGBE_ACTIVITY_SIZE	Committed 2008-06-30	Thomas Lee	Heikki Linnakangas
extend VacAttrStats to allowstavalues of different types	Committed 2008-07-01	Jan Urbański	Heikki Linnakangas
Jan Urbański says: updated patch here
Better formatting of functions in pg_dump	Committed 2008-07-01	Greg Sabino Mullane	Heikki Linnakangas
multi-version support for psql \d commands	Committed 2008-07-02	Guillaume Lelarge	Tom Lane
gleu says: updated patch here
pg_get_keywords()	Committed 2008-07-03	Dave Page	Nikhil Sontakke, Tom Lane
dpage says: updated patch here
nikhils says: review complete from my side. Updated patch along with comments posted back here
pg_standby keepfiles calc bug	Committed 2008-07-08	Simon Riggs	Heikki Linnakangas
Adding variables for segment_size, wal_segment_size and block sizes	Committed 2008-07-10	Bernd Helmle	Abhijit Menon-Sen, Tom Lane
multicolumn GIN	Committed 2008-07-11	Teodor Sigaev, Oleg Bartunov	Neil Conway, Tom Lane
teodor says: synced with CVS patch here. I'd like to commit this patch before GIN fast insert one
page macros cleanup	Committed 2008-07-13	Zdeněk Kotala	Pavan Deolasee, Heikki Linnakangas
Zdeněk says: updated patch here - ver 04
text search ANALYZE enhancements	Committed 2008-07-13	Jan Urbański	Tom Lane
tgl says: review here --- data structure could be improved and simplified
tgl says: updated version here
array_fill function	Committed 2008-07-15	Pavel Stěhule	Thomas Lee, Bruce Momjian
Custom variadic functions	Committed 2008-07-15	Pavel Stěhule	Jeff Davis, Tom Lane
pavel says: updated patch here
Review: Jeff Davis says: Minor issues
tgl says: comments posted here
pavel says: updated patch here
Table function support	Committed 2008-07-17	Pavel Stěhule	Marko Kreen, Tom Lane
Review: Marko Kreen says: Minor issues
Pavel Stehule says: update patch here
executor_hook	Committed 2008-07-18	Takahiro Itagaki	Simon Riggs
tgl says: don't like exposing ExecutePlan, why not hook at ExecutorRun?
itagaki says: updated patch here
pg_dump lock timeout	Committed 2008-07-20	David Gould	David Fetter, Stephen Frost
Review: Stephen Frost says: Couple of minor changes requested, otherwise good
Stephen Frost says: David Gould will make the changes agreed on and provide an update.
tgl says: updated version posted here
CITEXT: A case-insensitive TEXT type	Committed 2008-07-29	David E. Wheeler	Zdeněk Kotala
David Wheeler says: v2 patch here
David Wheeler says: v3 patch here
David Wheeler says: v4 patch here
Zdeněk Kotala says: Discussion about integration into to the core.
DTrace probe additions	Committed 2008-08-01	Robert Lor, Theo Schlossnagle	Álvaro Herrera

Returned with Feedback

Patch	Status	Author	Reviewers
Stats Hooks	Returned for rework	Simon Riggs	Tom Lane
Josh Berkus says: discussion of this patch is here
tgl says: review here --- won't work as submitted
EXPLAIN in XML format	Returned for rework	Tom Raney, Germán Poó Caamaño	Simon Riggs
David Fetter says: updated patch here
Simon Riggs says: comments posted on-list - IMHO not ready for commit
tgl says: I agree with Simon: the DTD problems are a show-stopper
libpq object hooks	WIP	Merlin Moncure, Andrew Chernow	Nobody
Josh Berkus says: deferred until September per post of submitter
GIN fast insert()	Returned for rework	Teodor Sigaev, Oleg Bartunov	Thomas Lee, Bruce Momjian
teodor says: updated patch here
thomas.lee says: will likely need somebody else to assist with this particular review as I'm relatively new to postgres
teodor says: synced with CVS patch here
teodor says: synced with CVS with already committed multicolumn GIN patch here
tgl says: updated patch here, plus note about hard-to-fix race conditions
pg_dump additional options for performance	Returned for rework	Simon Riggs	Stephen Frost, Tom Lane
Review: Stephen Frost says: minor nitpick, missing documentation
tgl says: updated patch here
Review: Stephen Frost says: minor nitpicks, missing cmd-line documentation
sfrost says: updated patch here
Review: Stephen Frost says: couple regressions/bugs to be fixed, minor nitpiks also
tgl says: updated patch here, with notes on work still needed
VACUUM Improvements - Avoiding second heap scan	WIP	Pavan Deolasee	Nobody
tgl says: reviews here and here
WITH RECURSIVE	WIP	Yoshiyuki Asaba	David Fetter
Review: David Fetter says: Updated with fixes from Yoshiyuki Asaba and Michael Meskes
alvherre says: There's a long TODO list here
David Fetter says: update patch here
tgl says: this is so short of documentation that it's impossible to review it meaningfully
Extending permissions on tables to sequences	Returned for rework	Jaime Casanova	Abhijit Menon-Sen
Abhijit Menon-Sen says: The patch looks OK (modulo some nits), but do we want the feature at all?
Jaime Casanova says: updated patch here
tgl says: here are some things to think about before we can accept the patch
pg_standby minor changes for Windows	Rejected	Simon Riggs	Martin Zaun
tgl says: the consensus seems to be that this is the wrong solution
SIGINFO to EXPLAIN queries in progress	Returned for rework	Greg Stark	Nobody
tgl says: seems to me this was already adequately reviewed (and mostly rejected) in the original thread
heikki says: I think the idea has merit, but the question on overhead needs to be addressed, and the API needs some thinking too:
Auto-Explain	Returned for rework	Dean Rasheed	Nobody
Simon Riggs says: Code location needs review; change proposal made to -hackers
tgl says: updated patch is here
tgl says: some comments here
SSL configure patch	Waiting for response	Mark Woodward	Abhijit Menon-Sen
ams says: review here with some issues, updated patch here
alvherre says: newer patch here, still some issues
Relation forks	About to commit	Heikki Linnakangas	Tom Lane
tgl says: looks committable after addressing these minor nits
alvherre says: Heikki posted a new version, supposedly ready to commmit
Hint Bits and Write I/O	Waiting for response	Simon Riggs	Pavan Deolasee
Pavan Deolasee says: Some performance numbers and at least one tuning patch would help
FSM rewrite	WIP	Heikki Linnakangas	Nobody
Simon Riggs says: comments posted on-list with further ideas
alvherre says: updated patch by Heikki
Collation at database level	WIP	Radek Strnad	Nobody
tgl says: Peter posted a short review here

Round Robin Reviewers

Name	Status	Patch Count
Neil Conway	Available	0
Jeff Davis	Available	1
Pavan Deolasee	Available	2
Andrew Dunstan	Vacation	0
Stephen Frost	Available	2
Álvaro Herrera	Available	0
Zdeněk Kotala	Available	2
Thomas Lee	Available	2
Abhijit Menon-Sen	Available	3
Bruce Momjian	Available	2
Nikhil Sontakke	Available	1
Greg Stark	Available	1
Martin Zaun	Available	1